Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): main popup now shows 0 for empty schedule #395

Conversation

Rishthegreat
Copy link
Contributor

@Rishthegreat Rishthegreat commented Oct 25, 2024

Fixed the issue where the Main popup icon was not showing the number 0 when a schedule with 0 hours was selected.

image

image


This change is Reviewable

Resolves #343

Copy link
Collaborator

@Samathingamajig Samathingamajig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code good, awaiting UI review from @IsaDavRod

@DereC4 DereC4 added the bugfix label Oct 26, 2024
@DereC4 DereC4 added this to the v2.1.0 milestone Oct 26, 2024
Copy link
Member

@IsaDavRod IsaDavRod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samathingamajig Samathingamajig merged commit 8de88d6 into Longhorn-Developers:main Oct 27, 2024
8 checks passed
Samathingamajig added a commit to nikshitak/UT-Registration-Plus that referenced this pull request Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Main Popup icon should show the number 0 if an empty schedule is selected.
4 participants