-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: UTRP v2 migration #292
Conversation
…stration-Plus into feature/v2-migration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modify text to remove migration language and match the language on the Figma
Change button color to ut-green to make the button stand out more
Move the announcement section above the Useful Links section
Some thoughts:
|
Thank you for your thoughts. Let’s use ut-green to make it stand out. Since we’re adding courses, we can add a green button in the branding for that purpose. For now, the migration announcement is only displayed above the Useful Links section. Most users will open the calendar for the first time and experience immediate stress when they see that their saved schedule and hard work is gone. If the migration is automatic and the button serves as a “backup” in case of failure, then we can move the Migration Announcement section below the Useful Links section. If we want to stick to UI/UX principles, the Migration section should only appear once and be hidden if the schedule is successfully migrated. In that case, we can implement a toggle “migrationComplete” that stores and sets to true after the user completes their migration. |
Derek Chen will return |
src/views/components/injected/CourseCatalogInjectedPopup/CourseCatalogInjectedPopup.tsx
Outdated
Show resolved
Hide resolved
a86328b
to
16f6e56
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
note: we're going to (attempt to) do a large-scale test at the meeting tonight |
63d5f64
to
c58bb2d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it, it works. LGTM
TODO
activeSchedule
is not updated after switching to the new scheduleUTRP v1 Migration
already exists for some reason, it might cause bugsonUpdate
onUpdate
didn't seem to work properly withpnpm run build:watch
but manually pressing the Migrate UTRP v1 courses button worked.pnpm run dev
works too.Issues that need to be resolved
Quoted from @Samathingamajig
Huly®: UTRP-289
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)