fix: disabled [object Object] hover message on dialog popups #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch! Somehow I thought this was an issue with headless and the way I was using the title component, but the fact that the props are passed in directly makes more sense 🤦 |
Razboy20
requested changes
Oct 8, 2024
Razboy20
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Root cause seems to be that rendering a component with an attribute namedtitlewill display some sort of hover message -> "[object Object]" appearing in tooltip when hovering column header bvaughn/react-virtualized#1176Edit: the issue can also be fixed by properly destructuring title. Thanks to @Razboy20 for the suggestion
Screen.Recording.2024-10-07.at.4.40.18.PM.mov
Screen.Recording.2024-10-07.at.4.51.13.PM.mov
This change is
This change is
This change is