Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable TS strict mode #168

Merged
merged 58 commits into from
Mar 21, 2024
Merged

feat: enable TS strict mode #168

merged 58 commits into from
Mar 21, 2024

Conversation

doprz
Copy link
Collaborator

@doprz doprz commented Mar 15, 2024 •
edited by Razboy20
Loading

This change is Reviewable

@doprz doprz requested a review from Razboy20 March 15, 2024 05:43
@doprz doprz self-assigned this Mar 15, 2024
@Lukas-Zenick Lukas-Zenick self-requested a review March 15, 2024 16:32
doprz and others added 15 commits March 15, 2024 20:15
@Razboy20 Razboy20 marked this pull request as ready for review March 21, 2024 07:00
Razboy20
Razboy20 approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@Razboy20 Razboy20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 13 files at r1, 2 of 6 files at r2, 53 of 54 files at r3, 18 of 18 files at r4, 18 of 18 files at r5, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Lukas-Zenick)

Razboy20
Razboy20 reviewed Mar 21, 2024
View reviewed changes
Copy link
Member

@Razboy20 Razboy20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 62 of 63 files reviewed, 2 unresolved discussions (waiting on @Lukas-Zenick)

doprz
doprz commented Mar 21, 2024
View reviewed changes
Copy link
Collaborator Author

@doprz doprz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@doprz doprz merged commit efed1c0 into main Mar 21, 2024
11 checks passed
@doprz doprz deleted the feature/ts-strict branch March 21, 2024 18:19
@doprz doprz mentioned this pull request Mar 21, 2024
Closed
caseycharleston pushed a commit to caseycharleston/UT-Registration-Plus that referenced this pull request Mar 30, 2024
@doprz @Lukas-Zenick
@Razboy20 @caseycharleston
feat: enable TS strict mode (Longhorn-Developers#168)
8ce011c 
* feat: enable TS strict mode

* fix: strict TS errors

* fix: strict TS errors

* fix: strict TS errors

* fix: strict TS errors

* fix: strict TS errors

* fix: strict TS errors

* fix: strict TS errors

* fix: strict TS errors

* fix: colors bug with default

* fix: strict TS errors

* fix: strict TS errors

* fix: strict TS errors

* fix: strict TS errors

* fix: strict TS errors

* fix: strict TS errors

* fix: strict TS errors

* fix: strict TS errors

* fix: strict TS errors

* fix: strict TS errors

* fix: strict TS errors

* fix: text type errors

* fix: strict TS errors

* fix: strict TS errors

* fix: strict TS errors - add definite assignment assertion

* fix: strict TS errors - add definite assignment assertion

* fix: strict TS errors

* fix: strict TS errors

* fix: strict TS errors

* fix: strict TS errors

* fix: strict TS errors

* fix: strict TS errors

* fix(ESLint): error on no-explicit-any

* fix: type annotations for any types

* fix: strict TS errors

* fix: strict TS errors

* fix: strict TS errors

* fix: strict TS errors (and remove packages)

* fix: strict TS errors

* fix: strict TS errors

* fix: strict TS errors

* fix: strict TS errors

* fix: strict TS errors

* fix: strict TS errors

* fix: strict TS errors

* feat: enable React.StrictMode

* fix: strict TS errors (done!)

* fix: build error

* fix: replace no-explicit-any assertions

* refactor: cleanup

* refactor: more cleanup

* style: prettier

---------

Co-authored-by: Lukas Zenick <lukas@utexas.edu>
Co-authored-by: Razboy20 <razboy20@gmail.com>
caseycharleston pushed a commit to caseycharleston/UT-Registration-Plus that referenced this pull request Mar 30, 2024
@doprz @Lukas-Zenick
@Razboy20 @caseycharleston
feat: enable TS strict mode (Longhorn-Developers#168)
7dee7c8 
* feat: enable TS strict mode

* fix: strict TS errors

* fix: strict TS errors

* fix: strict TS errors

* fix: strict TS errors

* fix: strict TS errors

* fix: strict TS errors

* fix: strict TS errors

* fix: strict TS errors

* fix: colors bug with default

* fix: strict TS errors

* fix: strict TS errors

* fix: strict TS errors

* fix: strict TS errors

* fix: strict TS errors

* fix: strict TS errors

* fix: strict TS errors

* fix: strict TS errors

* fix: strict TS errors

* fix: strict TS errors

* fix: strict TS errors

* fix: text type errors

* fix: strict TS errors

* fix: strict TS errors

* fix: strict TS errors - add definite assignment assertion

* fix: strict TS errors - add definite assignment assertion

* fix: strict TS errors

* fix: strict TS errors

* fix: strict TS errors

* fix: strict TS errors

* fix: strict TS errors

* fix: strict TS errors

* fix(ESLint): error on no-explicit-any

* fix: type annotations for any types

* fix: strict TS errors

* fix: strict TS errors

* fix: strict TS errors

* fix: strict TS errors (and remove packages)

* fix: strict TS errors

* fix: strict TS errors

* fix: strict TS errors

* fix: strict TS errors

* fix: strict TS errors

* fix: strict TS errors

* fix: strict TS errors

* feat: enable React.StrictMode

* fix: strict TS errors (done!)

* fix: build error

* fix: replace no-explicit-any assertions

* refactor: cleanup

* refactor: more cleanup

* style: prettier

---------

Co-authored-by: Lukas Zenick <lukas@utexas.edu>
Co-authored-by: Razboy20 <razboy20@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Razboy20 Razboy20 Razboy20 approved these changes

@Lukas-Zenick Lukas-Zenick Awaiting requested review from Lukas-Zenick

Assignees

@doprz doprz

Labels
ready-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@doprz @Razboy20 @Lukas-Zenick