fix: correct parsing of noon #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Samathingamajig
commented
Mar 13, 2024
|
who thought 10am --> 11am --> 12pm --> 1pm --> 2pm, and 10pm --> 11pm --> 12am --> 1am --> 2am was a good idea lol |
Razboy20
requested changes
Mar 13, 2024
Razboy20
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before: classes start/ending at noon (or anything 12:xx am/pm) mess up their start/end time, which can also mess up how conflicts are handled
(see the first instance of "endTime", should be 12 * 60 === 720, but an extra 12 hours is added)
(this shouldn't be conflicting with a 10am-12pm class)
after: corrected