fix: divider usage in HeaderAndActions #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doprz
requested changes
Feb 28, 2024
| @@ -50,6 +51,12 @@ const exampleCourse: Course = new Course({ | |||
| }, | |||
| }); | |||
|
|
|||
| const exampleSchedule: UserSchedule = new UserSchedule({ | |||
There was a problem hiding this comment.
nit
From lines 60-66 I'm pretty sure that it should be written like this:
const meta = {
title: 'Components/Injected/CourseCatalogInjectedPopup',
component: CourseCatalogInjectedPopup,
argTypes: {
onClose: { action: 'onClose' },
},
} satisfies Meta<typeof CourseCatalogInjectedPopup>;There was a problem hiding this comment.
I'm getting this error
There was a problem hiding this comment.
Maybe we skip storybook typing issues for now and continue onto extension features?
There was a problem hiding this comment.
Weird, it should work. I think I know the issue but it's fine if you skip this for now.
src/views/components/injected/CourseCatalogInjectedPopup/HeadingAndActions.tsx
Outdated
Show resolved
Hide resolved
|
Also small nit. Check |
doprz
approved these changes
Feb 28, 2024
doprz
pushed a commit
that referenced
this pull request
Mar 6, 2024
* fix: use StatusType * fix: use AutoLoadStatus * fix: use typof SiteSupport.* * fix: one more of Status to StatusType * fix: use import type * fix: use path alias imports * fix: use Extract * fix: remove unnecessary import * fix: **revert this later** - comment out build errs * fix: add schedule to story * feat: add props for dividers * revert: un-comment build errors This reverts commit 082e9e0. * Revert "fix: remove unnecessary import" This reverts commit 9230346. * Revert "fix: use Extract" This reverts commit f6aa80d. * Revert "fix: use path alias imports" This reverts commit ea9bf3c. * Revert "fix: use import type" This reverts commit 27fee47. * Revert "Merge branch 'fix/Status-to-StatusType' into fix/divider-usage" This reverts commit b1715ea, reversing changes made to 9ccc43c. * fix: dont use magic number * fix: lint errs * fix: reorder imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what it looks like now, the previous code didn't use the correct props. I also had to edit the story slightly since it didn't pass in a schedule which caused a bug.
Ignore the commit history, I accidentally included other commits so I had to revert them - rebase wasn't working