-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for structured html-validate output (OSOE-770) #337
Comments
Hello @AydinE, We use HTML validation in our UI tests, see: https://github.com/Lombiq/UI-Testing-Toolbox/blob/68d72b676e7ba75882a4887df325e5b05ddd793e/Lombiq.Tests.UI/Docs/Tools.md#:~:text=HTML%20markup%20validation%20can%20be%20done%20with%20html%2Dvalidate%20via%20Atata.HtmlValidation.
The relation is only this part: atata-framework/atata-htmlvalidation#8. So if there is an HTML validation problem it renders like this:
This is okay, but in the code, it's also just one big A good example of that is what the accessibility checking does: https://github.com/Lombiq/UI-Testing-Toolbox/blob/68d72b676e7ba75882a4887df325e5b05ddd793e/Lombiq.Tests.UI/Docs/Tools.md#:~:text=Accessibility%20checking%20can%20be%20done%20with%20axe%20via%20Selenium.Axe%20for%20.NET. |
Is this addressed?
|
Yes, but we did in a way, that the output is still human readable, both the file and the output in VS. But at the same time, you can ignore rules easier |
OK, great! |
html-validate
, what we use for HTML validation under the hood withAtata.HtmlValidation
, supports multiple formatters for the output, including JSON.Based on this, add support for a structured HTML validation output, i.e. a collection of .NET objects (perhaps by deserializing the JSON output). This will be then useful to have custom assertions for.
Keep the simple text output too, but this output should from then on be the recommended way. Change all built-in features to use that.
Related: atata-framework/atata-htmlvalidation#8.
Jira issue
The text was updated successfully, but these errors were encountered: