Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-10: "Layers and Zones" recipe and SCSS mixin improvement. #6

Merged
merged 9 commits into from
Feb 11, 2022
Merged

SNOW-10: "Layers and Zones" recipe and SCSS mixin improvement. #6

merged 9 commits into from
Feb 11, 2022

Conversation

sarahelsaig
Copy link
Member

@Piedone
Copy link
Member

Piedone commented Feb 4, 2022 •
edited
Loading

Remarks from elsewhere:

  1. The Readme title doesn't follow the necessary pattern. Should be "Lombiq Base Theme for Orchard Core".
  2. Manifest doesn't follow it either, should be "Lombiq Base Theme".
  3. navigationTogglerIcon should potentially have an alt instead of or in addition to a title.

@Piedone
Copy link
Member

Piedone commented Feb 7, 2022

What about "navigationTogglerIcon should potentially have an alt instead of or in addition to a title"?

@sarahelsaig
Copy link
Member Author

sarahelsaig commented Feb 7, 2022 •
edited
Loading

Looks like I've accidentally only changed one of the two.

EDIT: fixed

@barthamark barthamark merged commit 4b70e2b into dev Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barthamark barthamark barthamark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sarahelsaig @Piedone @barthamark