OSOE-127: Upgrade to Orchard Core 1.4 #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahelsaig
requested changes
Jun 6, 2022
| @@ -39,6 +39,6 @@ public static async Task TestMainMenuWithAuthenticationAsync(this UITestContext | |||
| await context.ClickMainMenuPathAsync("Account", "Log Out"); | |||
|
|
|||
| await context.ClickMainMenuPathAsync("Log In"); | |||
| context.Exists(By.XPath("//form[@action = '/Login']/h4[contains(., 'Log in')]")); | |||
| context.Exists(By.XPath("//form[@action = '/Login']/h1[contains(., 'Log in')]")); | |||
There was a problem hiding this comment.
I don't think the header level matters here so we can generalize:
Suggested change
| context.Exists(By.XPath("//form[@action = '/Login']/h1[contains(., 'Log in')]")); | |
| context.Exists(By.XPath("//form[@action = '/Login']/*[starts-with(name(), 'H') and contains(., 'Log in')]")); |
There was a problem hiding this comment.
fml it's H in Firefox but h in Chrome and I only checked in the dev console.
…nsions.cs Co-authored-by: Dávid El-Saig <david.el-saig@lombiq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSOE-127