-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSOE-93: Fixing style lint error custom-property-empty-line-before #17
Merged
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
08af5fc
Fixing style lint error: Unexpected empty line before custom property…
dministro f1a2dee
updating manifest version
dministro 9bc8372
Merge branch 'dev' of https://github.com/Lombiq/Orchard-Base-Theme in…
dministro f25f758
Merge branch 'dev' of https://github.com/Lombiq/Orchard-Base-Theme in…
dministro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Next time don't skip a minor version when publishing an alpha (the current version at the time was 1.0.0 so this should have been 1.0.1-alpha): https://lombiq.atlassian.net/wiki/spaces/DEV/pages/786857987/Managing+releases+of+open-source+projects#:~:text=When%20publishing%20a%20pre%2Drelease%20version%20for%20something%20temporary%20you%20do%20under%20an%20issue%2C%20then%20always%20use%20the%20next%20patch%20version%20with%20a%20suffix.%20E.g.%20if%20the%20current%20latest%20released%20version%20if%201.2.3%20then%20publish%201.2.4%2Dalpha.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I made this, there was a 1.0.1-alpha already on nuget, and it was @DAud-IcI version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll clarify the docs but it refers to the latest released version. (All this is important for proper releases on GitHub.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps it would be a good idea to include the issue code in the version code, such as
1.0.1-alpha.osoe-93.1
or something along the lines, so it won't be confusing when two branches need to make independent pre-releases. What do you think @Piedone ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That did occur to me but it didn't seem like a polite thing to do on NuGet, to mix in our issues. But I suppose these pre-releases are adding some pollution anyway, we can try.