Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSOE-733: Adding default value for the browser used during UI testing #76

Merged
merged 5 commits into from
Nov 26, 2023
Merged

OSOE-733: Adding default value for the browser used during UI testing #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fc8c6f6
Adding default value for the browser used during UI testing
Piedone Nov 22, 2023
726ef33
Updating Lombiq.Tests.UI package reference to latest
Piedone Nov 23, 2023
f003f03
Formatting
Piedone Nov 23, 2023
508dd94
Removing now unneeded feature enable from UI test
Piedone Nov 23, 2023
cc03a32
Merge remote-tracking branch 'origin/dev' into issue/OSOE-733
Piedone Nov 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ure.ApplicationInsights.Tests.UI/Lombiq.Hosting.Azure.ApplicationInsights.Tests.UI.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
</ItemGroup>

<ItemGroup Condition="'$(NuGetBuild)' == 'true'">
<PackageReference Include="Lombiq.Tests.UI" Version="8.1.0-alpha.1.osoe-638" />
<PackageReference Include="Lombiq.Tests.UI" Version="8.2.1-alpha.1.osoe-733" />
<PackageReference Include="Lombiq.Privacy.Tests.UI" Version="7.0.2-alpha.2.osoe-638" />
</ItemGroup>

Expand Down
8 changes: 3 additions & 5 deletions Lombiq.Hosting.Azure.ApplicationInsights.Tests.UI/TestCases/ApplicationInsightsTestCases.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,19 +12,17 @@ public static class ApplicationInsightsTestCases
{
public static Task ApplicationInsightsTrackingInOfflineOperationShouldWorkAsync(
ExecuteTestAfterSetupAsync executeTestAfterSetupAsync,
Browser browser,
Browser browser = default,
Func<OrchardCoreUITestExecutorConfiguration, Task> changeConfigurationAsync = null) =>
executeTestAfterSetupAsync(
async context =>
{
await context.EnableFeatureDirectlyAsync("Lombiq.Hosting.Azure.ApplicationInsights");

await context.EnablePrivacyConsentBannerFeatureAndAcceptPrivacyConsentAsync();

var appInsightsExist = context.ExecuteScript("return window.appInsights === 'enabled'") as bool?;

// Our custom message helps debugging, otherwise from the test output you could only tell that a value should be
// true but is false which is less than helpful.
// Our custom message helps debugging, otherwise from the test output you could only tell that a value
// should be true but is false which is less than helpful.
appInsightsExist.ShouldBe(expected: true, "The Application Insights module is not working or is not in offline mode.");
},
browser,
Expand Down