From 13d2b3c0ff31c4004b20e0d135f9a5aab90816c9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Roland=20M=C3=A1rkus?= Date: Sun, 16 Jun 2024 21:46:15 +0200 Subject: [PATCH 1/2] Adding explaining comment to avoid removing SaveAsync() --- .../Services/EmailQuotaService.cs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Lombiq.Hosting.Tenants.EmailQuotaManagement/Services/EmailQuotaService.cs b/Lombiq.Hosting.Tenants.EmailQuotaManagement/Services/EmailQuotaService.cs index 92af9ffb..e3566e4a 100644 --- a/Lombiq.Hosting.Tenants.EmailQuotaManagement/Services/EmailQuotaService.cs +++ b/Lombiq.Hosting.Tenants.EmailQuotaManagement/Services/EmailQuotaService.cs @@ -19,6 +19,8 @@ namespace Lombiq.Hosting.Tenants.EmailQuotaManagement.Services; +// As noted under github issue https://github.com/OrchardCMS/OrchardCore/issues/15290#issuecomment-2093363619 +// SaveAsync calls should be removed due to redundancy, however removing them breaks functionality. public class EmailQuotaService : IEmailQuotaService { private readonly ISession _session; From 4de4b22dc3525cac9c1b21d61d9f566bd399dd61 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Mon, 17 Jun 2024 00:40:32 +0200 Subject: [PATCH 2/2] Spelling/grammar --- .../Services/EmailQuotaService.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Lombiq.Hosting.Tenants.EmailQuotaManagement/Services/EmailQuotaService.cs b/Lombiq.Hosting.Tenants.EmailQuotaManagement/Services/EmailQuotaService.cs index e3566e4a..dc45845a 100644 --- a/Lombiq.Hosting.Tenants.EmailQuotaManagement/Services/EmailQuotaService.cs +++ b/Lombiq.Hosting.Tenants.EmailQuotaManagement/Services/EmailQuotaService.cs @@ -19,8 +19,8 @@ namespace Lombiq.Hosting.Tenants.EmailQuotaManagement.Services; -// As noted under github issue https://github.com/OrchardCMS/OrchardCore/issues/15290#issuecomment-2093363619 -// SaveAsync calls should be removed due to redundancy, however removing them breaks functionality. +// As noted under the GitHub issue https://github.com/OrchardCMS/OrchardCore/issues/15290#issuecomment-2093363619 +// SaveAsync calls could be removed due to redundancy, however, removing them actually breaks functionality. public class EmailQuotaService : IEmailQuotaService { private readonly ISession _session;