Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSOE-183: Setting "ui-test-parallelism" results in error #48

Merged
merged 3 commits into from
Sep 8, 2022
Merged

OSOE-183: Setting "ui-test-parallelism" results in error #48

merged 3 commits into from
Sep 8, 2022

Conversation

Piedone
Copy link
Member

@Piedone Piedone commented Sep 7, 2022

OSOE-183

Fixes #47

dministro
dministro requested changes Sep 8, 2022
View reviewed changes
Copy link
Member

@dministro dministro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error is still present.

@Piedone
Copy link
Member Author

Piedone commented Sep 8, 2022

You just tried to use it in the job that refers to the dev branch. I only pointed the call-build-and-test-workflow-nuget-test job to the issue branch: Lombiq/Open-Source-Orchard-Core-Extensions@eaeaa6f#diff-bc668a2c9f2299cef15b222055b4b4d5311646caec2e7610e540cee18ae9b948R21 You can either try out changing these configs in that job, or also point the call-build-and-test-workflow job to the issue branch.

@dministro
Copy link
Member

You are right. This was my fault.

@dministro dministro merged commit ce430b2 into dev Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dministro dministro dministro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setting "ui-test-parallelism" results in error (OSOE-183)
2 participants
@Piedone @dministro