Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSOE-842: Removing the NuGetBuild property after adding the SourceLink package during NuGet publishing #344

Merged
merged 8 commits into from
May 1, 2024
Merged

OSOE-842: Removing the NuGetBuild property after adding the SourceLink package during NuGet publishing #344

merged 8 commits into from
May 1, 2024

Conversation

Piedone
Copy link
Member

@Piedone Piedone commented May 1, 2024 •
edited
Loading

OSOE-842
This was introduced by #343.

Fixes #342 Fixes this problem: OrchardCMS/OrchardCore.Commerce#435 (comment)

@github-actions github-actions bot changed the title Removing the NuGetBuild property after adding the SourceLink package during NuGet publishing OSOE-842: Removing the NuGetBuild property after adding the SourceLink package during NuGet publishing May 1, 2024
@sarahelsaig sarahelsaig enabled auto-merge May 1, 2024 17:32
@sarahelsaig sarahelsaig added this pull request to the merge queue May 1, 2024
Merged via the queue into dev with commit 5f456a1 May 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahelsaig sarahelsaig sarahelsaig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix NuGetBuild not taking effect in the publish-nuget action (OSOE-842)
2 participants
@Piedone @sarahelsaig