Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LMBQ-267: Adding "XSS" to the Security spelling dictionary, centralized Add/Remove Label internal action #336

Merged
merged 13 commits into from
Apr 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions .github/actions/add-remove-label/action.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
name: Add/Remove Label
description: >
Runs buildsville/add-remove-label. Exists only to centralize which version of the action we use. Intentionally not
documented in Actions.md since it's only meant for internal use.

# Copied from https://github.com/buildsville/add-remove-label/blob/master/action.yml.
inputs:
token:
description: 'github token'
required: true
default: ''
labels:
description: 'labels to edit'
required: false
default: ''
label:
description: 'label to edit'
required: false
default: ''
type:
description: 'add or remove'
required: true
default: ''

runs:
using: "composite"
steps:
- name: Add/Remove Label
# v2.0.1
uses: buildsville/add-remove-label@ac59c9f0aeb66eb12d6366eb1d69ec1906e9ef9a
with:
token: ${{ inputs.token }}
labels: ${{ inputs.labels }}
label: ${{ inputs.label }}
type: ${{ inputs.type }}
3 changes: 1 addition & 2 deletions .github/actions/auto-merge-pull-request/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,7 @@ runs:

- name: Remove Label
if: steps.check-mergeability.outputs.contains-label == 'true'
# v2.0.0
uses: buildsville/add-remove-label@eeae411a9be2e173f2420e1644514edbecc4e835
uses: Lombiq/GitHub-Actions/.github/actions/add-remove-label@dev
with:
token: ${{ env.GITHUB_TOKEN }}
labels: merge-if-checks-succeed
Expand Down
3 changes: 1 addition & 2 deletions .github/actions/auto-transition-jira-issue/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,7 @@ runs:
Set-JiraIssueStatus @parameters

- name: Remove Label
# v2.0.0
uses: buildsville/add-remove-label@eeae411a9be2e173f2420e1644514edbecc4e835
uses: Lombiq/GitHub-Actions/.github/actions/add-remove-label@dev
with:
token: ${{ env.GITHUB_TOKEN }}
labels: merge-and-resolve-jira-issue-if-checks-succeed, resolve-jira-issue-if-checks-succeed, done-jira-issue-if-checks-succeed
Expand Down
2 changes: 2 additions & 0 deletions .github/actions/spelling/dictionaries/Security.txt
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,5 @@ clickjacking
nosniff
softwaresecurityproject
PII
XSS
Xss
4 changes: 3 additions & 1 deletion .github/actions/verify-dotnet-consolidation/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,9 @@ inputs:
exclude-version-regex:
required: false
default: '\-alpha'
description: A regular expression to match package versions that will be skipped during checking.
description: >
A regular expression to match package versions that will be skipped during NuGet package consolidation. See the
dotnet consolidate docs for details: https://github.com/olsh/dotnet-consolidate?tab=readme-ov-file#usage.

runs:
using: "composite"
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/build-and-test-dotnet.yml
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,8 @@ on:
required: false
default: '\-alpha'
description: >
A regular expression to match package versions that will be skipped during NuGet package consolidation.
A regular expression to match package versions that will be skipped during NuGet package consolidation. See
the dotnet consolidate docs for details: https://github.com/olsh/dotnet-consolidate?tab=readme-ov-file#usage.
warnings-as-errors:
type: string
default: 'true'
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/build-and-test-orchard-core.yml
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,8 @@ on:
required: false
default: '\-alpha'
description: >
A regular expression to match package versions that will be skipped during NuGet package consolidation.
A regular expression to match package versions that will be skipped during NuGet package consolidation. See
the dotnet consolidate docs for details: https://github.com/olsh/dotnet-consolidate?tab=readme-ov-file#usage.
warnings-as-errors:
type: string
default: 'true'
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/post-pull-request-checks-automation.yml
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,7 @@ jobs:

- name: Remove Label
if: steps.check-steps-should-run.outputs.is-latest != 'false'
# v2.0.0
uses: buildsville/add-remove-label@eeae411a9be2e173f2420e1644514edbecc4e835
uses: Lombiq/GitHub-Actions/.github/actions/add-remove-label@dev
with:
token: ${{ env.MERGE_TOKEN }}
labels: merge-and-resolve-jira-issue-if-checks-succeed
Expand Down
Loading