OSOE-165: Fixing NuGet publishing for repositories without an sln file #30
Conversation
| @@ -16,7 +16,16 @@ | |||
|
|
|||
| param([array] $Arguments) | |||
|
|
|||
| foreach ($project in (dotnet sln list | Select-Object -Skip 2 | Get-Item)) | |||
| if (!(Get-ChildItem *.sln)) | |||
There was a problem hiding this comment.
Let's stick with -not for neqation instead of the undocumented exclamation mark. However if you swap the if-else then you don't need any negation in the first place and save an extra pair of parens too.
Also Test-Path would be more expressive here than Get-ChildItem.
There was a problem hiding this comment.
Isn't the first one something the analyzers should catch?
There was a problem hiding this comment.
I agree, it should. I've opened an issue.
| if (!(Get-ChildItem *.sln)) | ||
| { | ||
| $projects = Get-ChildItem *.csproj | ||
| } | ||
| else | ||
| { | ||
| $projects = (dotnet sln list | Select-Object -Skip 2 | Get-Item) | ||
| } |
There was a problem hiding this comment.
In PowerShell statements return a value too. This is so beautiful it brings tears to my eyes.
So you can do
$projects = if ( ... )
{
}
else
{
}instead of assigning to the variable in each branch.
There was a problem hiding this comment.
Seems like poor man's ternary operator to me! Fortunately, PS 7 has actual ternary operators. I briefly contemplated keeping Windows PowerShell compatibility.
There was a problem hiding this comment.
It's more like a rich man's ternary operator because you can have multiple expressions in each arm so it's more powerful than a ternary. But yes, please use ternary then. This repo is already not compatible with Windows PowerShell.
There was a problem hiding this comment.
Indeed, and it's lavish with all the characters. Almost like showing off! :D
OSOE-165