Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make links darker blue for legibility? #8

Open
gilliankerr opened this issue Dec 16, 2016 · 0 comments
Open

Make links darker blue for legibility? #8

gilliankerr opened this issue Dec 16, 2016 · 0 comments

Comments

@gilliankerr
Copy link

@gilliankerr commented on Fri Nov 04 2016

Not enough contrast for visual impairments (let's discuss this). Is there guidance from WAI, W3C?


@gilliankerr commented on Fri Nov 04 2016

WCAG 2.0 Guideline 1.4.3

The visual presentation of text and images of text has a contrast ratio of at least 4.5:1, except for the following: (Level AA)

Large Text: Large-scale text and images of large-scale text have a contrast ratio of at least 3:1;
Incidental: Text or images of text that are part of an inactive user interface component, that are pure decoration, that are not visible to anyone, or that are part of a picture that contains significant other visual content, have no contrast requirement.
Logotypes: Text that is part of a logo or brand name has no minimum contrast requirement.
From http://accessibility.psu.edu/color/contrasthtml/


@LegoStormtroopr commented on Sun Nov 06 2016

Can you specify which links this impacts? Also have you checked the page with a colour checker like: http://www.checkmycolours.com/ ?

I'm certain there are areas that can be fixed, plus since you are using the default colours, if you identify links that do need improving can you open those bugs on https://github.com/aristotle-mdr/aristotle-metadata-registry ?


@gilliankerr commented on Mon Nov 07 2016

I looked at a couple of check my colours apps but they all ask the colour codes, which I don’t know (I’m using your default stylesheets). This is a generic web accessibility issue, not applicable to indicatoregistry.net

From: Samuel Spencer [mailto:notifications@github.com]
Sent: Sunday, November 6, 2016 17:22
To: LogicalOutcomes/aristotle-NGO aristotle-NGO@noreply.github.com
Cc: Gillian Kerr gillian@logicaloutcomes.net; Author author@noreply.github.com
Subject: Re: [LogicalOutcomes/aristotle-NGO] Make links darker blue for legibility? (#21)

Can you specify which links this impacts? Also have you checked the page with a colour checker like: http://www.checkmycolours.com/ ?

I'm certain there are areas that can be fixed, plus since you are using the default colours, if you identify links that do need improving can you open those bugs on https://github.com/aristotle-mdr/aristotle-metadata-registry ?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/LogicalOutcomes/aristotle-NGO/issues/21#issuecomment-258715645, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AD-5SduE01PCSGit5QCqykJ3d2jPqSZdks5q7lL2gaJpZM4Kp7om.


@LegoStormtroopr commented on Mon Nov 07 2016

The linked color checker (http://www.checkmycolours.com/) accepts a url and will check that page for any contrast issues, http://wave.webaim.org/ does similar.

Due to the number of links on the site this might impact, instead of checking every possible link, it will be helpful to target those which have issues to make the changes quicker.


@gilliankerr commented on Mon Nov 07 2016

Got it... I pasted in a random page and got 28 contrast errors. I think it is all the light blue links

http://www.indicatorregistry.net/item/535/indicator/financial-well-being

Luminosity Contrast Ratio: 28 failures
Brightness difference: 1 failures
Color difference: 28 failures

Sent by mobile; please excuse brevity

Dr. Gillian Kerr, C.Psych | President, LogicalOutcomes www.logicaloutcomes.nethttp://%20www.logicaloutcomes.net | direct (416) 531-7634 Toronto | Washington DC (202) 779-9634 ext 101 | Skype ID: gilliankerr | gillian@logicaloutcomes.net | Book a meeting with me at https://calendly.com/gilliankerr


From: Samuel Spencer notifications@github.com
Sent: Monday, November 7, 2016 3:56:02 PM
To: LogicalOutcomes/aristotle-NGO
Cc: Gillian Kerr; Author
Subject: Re: [LogicalOutcomes/aristotle-NGO] Make links darker blue for legibility? (#21)

The linked color checker (http://www.checkmycolours.com/) accepts a url and will check that page for any contrast issues, http://wave.webaim.org/ does similar.

Due to the number of links on the site this might impact, instead of checking every possible link, it will be helpful to target those which have issues to make the changes quicker.

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/LogicalOutcomes/aristotle-NGO/issues/21#issuecomment-258959929, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AD-5ScbjYOZqhRZ1p62zGD_R1qiLvt2eks5q75BigaJpZM4Kp7om.


@gilliankerr commented on Mon Nov 07 2016

Can you just darken all the blue links in css file?


@LegoStormtroopr commented on Mon Nov 07 2016

There are about 15 different CSS files for different contexts to help keep code contained.
We also have a few different variants of colours for different contexts and they appear on different backgrounds.

Despite what appears to be a very simple change, it is a matter of identifying which classes of links need to be changed. I have other competing priorities this week so I may not be able to identify the links and resolve this this week.

Can we discuss this more on todays call?


@gilliankerr commented on Tue Nov 08 2016

Let's add this issue to the backlog then or move it to the regular Aristotle github repo. It's a WAI-compliance issue that applies to government policy for both Canada and Australia, I would guess. When we get funding we can ask someone to go through it page by page or do a search and replace on css or whatever seems most efficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant