Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor some of the util functions to return Result instead of Option #108

Open
CheatCod opened this issue Feb 13, 2023 · 0 comments
Open

refactor some of the util functions to return Result instead of Option #108

CheatCod opened this issue Feb 13, 2023 · 0 comments

Comments

@CheatCod
Copy link
Member

Description

For ex, get_vanilla_jar_url, get_fabric_jar_url etc all return options. Result would be preferable in this case since there are multiple points of potential failure in the function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@CheatCod