Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for labels_map argument #490

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Fix for labels_map argument #490

merged 2 commits into from
Aug 12, 2024

Conversation

rwood-97
Copy link
Collaborator

Summary

This was an oversight in #489 .
When getting the label indices from labels i was using the list of unique labels, but since the most recent changes the ordering of this list no longer reflects the ordering of labels in the labels map.

Now instead, we create an inverse of the labels map and use this to find the label index.

Checklist before assigning a reviewer (update as needed)

  • Self-review code
  • Ensure submission passes current tests
  • Add tests
  • [] Update relevant docs

Reviewer checklist

Please add anything you want reviewers to specifically focus/comment on.

  • Everything looks ok?

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.79%. Comparing base (7de87ef) to head (5c9fc6f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #490      +/-   ##
==========================================
+ Coverage   65.74%   65.79%   +0.05%     
==========================================
  Files          46       46              
  Lines        7467     7478      +11     
==========================================
+ Hits         4909     4920      +11     
  Misses       2558     2558              
Flag Coverage Δ
unittests 65.79% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rwood-97 rwood-97 merged commit 6eed2e2 into main Aug 12, 2024
8 checks passed
@rwood-97 rwood-97 deleted the labels_map_fix branch August 12, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant