Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Dashy new Container version "opening method" "modal" is faulty #1375

Closed
5 tasks done
Mimosinito opened this issue Nov 8, 2023 · 5 comments
Closed
5 tasks done
Assignees
Labels
🐛 Bug [ISSUE] Ticket describing something that isn't working 🔨 Fixed 🛩️ Released 2.1.2

Comments

@Mimosinito
Copy link

Mimosinito commented Nov 8, 2023

Bildschirmfoto_2023-11-08_15-16-47

Environment

Self-Hosted (Docker)

System

Firefox 119, XUbuntu 23.04, docker-ce 5:24.0.7-1debian.11bullseye

Version

Dashy Version 2.1.1 ✅ Aktuell

Describe the problem

Since last container update some entries with the opening method "modal" returns in the opening modal window a new dashy start screen. Some not.
Maybe the difference is, the entries have a in correct behavior don't get a complete website (html/header/body).

You can test the behavior with https://wttr.in

Additional info

No response

Please tick the boxes

@Mimosinito Mimosinito added the 🐛 Bug [ISSUE] Ticket describing something that isn't working label Nov 8, 2023
@github-project-automation github-project-automation bot moved this to Todo in Dashy V3 Nov 8, 2023
@liss-bot
Copy link
Collaborator

liss-bot commented Nov 8, 2023

If you're enjoying Dashy, consider dropping us a ⭐
🤖 I'm a bot, and this message was automated

@numanair
Copy link

It seems to open several modals on top of each other. If you click to the side of them you will see.

@liss-bot liss-bot added the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Nov 21, 2023
@rokiden
Copy link
Contributor

rokiden commented Nov 23, 2023

Pull request #1275 merged by d2e4949 broke modals. Checked using bot's preview.

@liss-bot liss-bot removed the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Nov 24, 2023
@UniqueName992
Copy link

Pull request #1275 merged by d2e4949 broke modals. Checked using bot's preview.

I'm also experiencing this issue.
Manually editing the file src/components/LinkItems/Section.vue undoing the changes listed in the PR and rebuilding the application does workaround this issue for me, providing the expected modal behavior without opening multiple modals on top of one another.

@liss-bot liss-bot added the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Jan 2, 2024
@Lissy93 Lissy93 moved this from Awaiting Triage to Up Next in Dashy V3 Jan 2, 2024
@CrazyWolf13 CrazyWolf13 moved this from Up Next to In Progress in Dashy V3 Feb 22, 2024
@CrazyWolf13 CrazyWolf13 self-assigned this Feb 22, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Dashy V3 Feb 22, 2024
@liss-bot liss-bot removed the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Feb 22, 2024
@liss-bot
Copy link
Collaborator

liss-bot commented Mar 3, 2024

The fix for this issue has now been released in 2.1.2 ✨

If you haven't done so already, please update your instance to 2.1.2 or later. See 2.1.2 for full info.

Feel free to reach out if you need any more support. If you are enjoying Dashy, consider supporting the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug [ISSUE] Ticket describing something that isn't working 🔨 Fixed 🛩️ Released 2.1.2
Projects
Status: Done
Development

No branches or pull requests

7 participants