This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Initialize genesis block correctly - Fixes #651 #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Isabello
suggested changes
Jul 3, 2017
modules/transactions.js
Outdated
| @@ -46,7 +46,7 @@ function Transactions (cb, scope) { | |||
| transaction: scope.logic.transaction, | |||
| }, | |||
| }; | |||
| genesisblock = library.genesisblock; | |||
| genesisblock = scope.genesisblock; | |||
There was a problem hiding this comment.
We should initialize it as part of library.
There was a problem hiding this comment.
We don't use it as a part of library in this file, we access genesisblock closure variable. Do we want to remove genesisblock variable and use library.genesisblock instead?
There was a problem hiding this comment.
I think that would be the best practice to switch to.
Isabello
approved these changes
Jul 3, 2017
LucasIsasmendi
approved these changes
Jul 3, 2017
MaciejBaj
approved these changes
Jul 3, 2017
karmacoma
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #651