-
Notifications
You must be signed in to change notification settings - Fork 458
Conversation
…hain is sending chain
…istration command
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## development #8247 +/- ##
===============================================
+ Coverage 83.06% 83.09% +0.02%
===============================================
Files 589 589
Lines 21807 21810 +3
Branches 3185 3192 +7
===============================================
+ Hits 18115 18122 +7
+ Misses 3692 3688 -4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. However some parts of the LIP PR were overlooked in the corresponding issue, so I added comments on things to be added.
Also, I don't understand why no change was needed in payMessageFee
. Was the implementation not aligned with the previous protocol?
framework/src/modules/interoperability/mainchain/commands/register_sidechain.ts
Show resolved
Hide resolved
To the best of my knowledge the changes recommended by the LIP for |
What was the problem?
This PR resolves #8165
How was it solved?
Added escrow initialisation in sidechain registration command execution.
Added check for receiving chain id in transfer cross chain command.
Added check for receiving chain id in initializeEscrowAccount
Added zero balance check in lock and unlock token module method.
As per the issue details;
payMessageFee method in token module didn't require any changes.
How was it tested?
Implemented unit tests.