Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Fix wrong min precommit height and overwrite of finality - Closes #4808 #4811

Merged
merged 5 commits into from
Feb 11, 2020
Merged

Fix wrong min precommit height and overwrite of finality - Closes #4808 #4811

merged 5 commits into from
Feb 11, 2020

Conversation

shuse2
Copy link
Collaborator

@shuse2 shuse2 commented Feb 10, 2020

What was the problem?

This PR resolves #4808

How was it solved?

  • Remove resetting the finality when recomputing
  • Fix not to throw error when cache doesn't exist
  • Fix the logic to for height count down

How was it tested?

  • it should not affect the property calculation on the success scenario
  • Removed the cache manually (not initialize enough in the code, and observe it doesn't throw)

@shuse2 shuse2 requested a review from nazarhussain February 10, 2020 08:30
@shuse2 shuse2 self-assigned this Feb 10, 2020
@shuse2 shuse2 requested a review from ManuGowda February 10, 2020 08:30
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@shuse2 shuse2 requested a review from nazarhussain February 10, 2020 19:12
@shuse2 shuse2 merged commit bb235ca into hotfix/3.0.2 Feb 11, 2020
@shuse2 shuse2 deleted the fix_invalid_height_access_and_finality branch February 11, 2020 08:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nazarhussain nazarhussain nazarhussain approved these changes

@ManuGowda ManuGowda Awaiting requested review from ManuGowda

Assignees

@shuse2 shuse2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shuse2 @nazarhussain