Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Add back nodeInfo, peerLimit and requestPacket fields to _peerSelectForRequest function - Closes #4142 #4143

Merged
merged 4 commits into from
Aug 26, 2019

Conversation

jondubois
Copy link
Contributor

@jondubois jondubois commented Aug 24, 2019

What was the problem?

  • Some useful fields were removed from the custom selection function which limits the ability of the P2P library to do advanced routing of requests.
  • There was an issue with the integration test related to peer eviction which made it brittle because the peers would not be started sequentially as was intended.

How did I solve it?

  • Added back missing fields when calling the selectForRequest function.
  • Fixed the integration test case so that each peer would wait one after another. Also, made each successive node point to the previous node instead of the next one (since the next one hasn't launched yet).

How to manually test it?

npm test

Review checklist

@jondubois jondubois force-pushed the 4142-select_for_request branch from b9ff2b5 to 4476609 Compare August 24, 2019 18:32
@jondubois jondubois changed the base branch from development to hotfix/2.3.1 August 24, 2019 18:33
@shuse2 shuse2 merged commit 07f732a into hotfix/2.3.1 Aug 26, 2019
@shuse2 shuse2 deleted the 4142-select_for_request branch August 26, 2019 11:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants