This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 458
Calculate consensus only from outbound connected peers - Closes #3969 #4134
Merged
shuse2
merged 15 commits into
hotfix/2.3.1
from
3969-consensus_from_outbound_peers_only
Aug 26, 2019
Merged
Calculate consensus only from outbound connected peers - Closes #3969 #4134
shuse2
merged 15 commits into
hotfix/2.3.1
from
3969-consensus_from_outbound_peers_only
Aug 26, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diego-G
force-pushed
the
3969-consensus_from_outbound_peers_only
branch
from
August 26, 2019 08:30
e85c1b4
to
d446154
Compare
mitsuaki-u
reviewed
Aug 26, 2019
mitsuaki-u
approved these changes
Aug 26, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM one comment to modify getUniqueConnectedPeers
diego-G
force-pushed
the
3969-consensus_from_outbound_peers_only
branch
from
August 26, 2019 09:45
d446154
to
09322a8
Compare
ishantiw
reviewed
Aug 26, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, just a couple of comments about whether we need to add an action to expose outbound list at the moment and about outbound peers test in peer_pool
diego-G
force-pushed
the
3969-consensus_from_outbound_peers_only
branch
from
August 26, 2019 11:35
49d1563
to
dbae947
Compare
ishantiw
approved these changes
Aug 26, 2019
shuse2
approved these changes
Aug 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to manually test it?
Review checklist