Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Calculate consensus only from outbound connected peers - Closes #3969 #4134

Merged
merged 15 commits into from
Aug 26, 2019

Conversation

diego-G
Copy link

@diego-G diego-G commented Aug 23, 2019

How to manually test it?

npx mocha --opts test/mocha/mocha.opts test/mocha/unit/modules/chain/peers.js
npx mocha --opts test/mocha/mocha.opts test/mocha/unit/modules/http_api/controllers/node.js
npx mocha --opts test/mocha/mocha.opts test/mocha/unit/modules/network/lookup_peers_ips.js 

Review checklist

@diego-G diego-G self-assigned this Aug 23, 2019
@diego-G diego-G requested a review from mitsuaki-u August 26, 2019 08:28
@diego-G diego-G force-pushed the 3969-consensus_from_outbound_peers_only branch from e85c1b4 to d446154 Compare August 26, 2019 08:30
Copy link
Contributor

@mitsuaki-u mitsuaki-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM one comment to modify getUniqueConnectedPeers

@diego-G diego-G force-pushed the 3969-consensus_from_outbound_peers_only branch from d446154 to 09322a8 Compare August 26, 2019 09:45
Copy link
Contributor

@ishantiw ishantiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just a couple of comments about whether we need to add an action to expose outbound list at the moment and about outbound peers test in peer_pool

framework/src/modules/network/index.js Show resolved Hide resolved
elements/lisk-p2p/test/unit/peer_pool.ts Show resolved Hide resolved
@diego-G diego-G force-pushed the 3969-consensus_from_outbound_peers_only branch from 49d1563 to dbae947 Compare August 26, 2019 11:35
@diego-G diego-G requested a review from ishantiw August 26, 2019 11:35
@shuse2 shuse2 merged commit e96d66a into hotfix/2.3.1 Aug 26, 2019
@shuse2 shuse2 deleted the 3969-consensus_from_outbound_peers_only branch August 26, 2019 12:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants