Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

executeCommon should match LIP #9009

Closed
Tracked by #7245
sitetester opened this issue Sep 19, 2023 · 0 comments
Closed
Tracked by #7245

executeCommon should match LIP #9009

sitetester opened this issue Sep 19, 2023 · 0 comments
Assignees
Milestone

Comments

@sitetester
Copy link
Contributor

sitetester commented Sep 19, 2023

Description

executeCommon(...) in base_cross_chain_update_command.ts doesn't fully align with LIP (as it has lately updated), e.g., in LIP, we have beforeCrossChainMessagesExecution (which further uses verifyRoutingRules), but these methods are not visible in current code.

Motivation

Existing code should match LIP so we inadvertently don't miss any important check(s).

Additional Information

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants