You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
In LIP we use integer division//. Line 157, 222, 300 has /.
line 222: BigInt(5) should be properly formulated considering (bftWeight * stakeRewardActiveValidators)//bftWeightSum. Also would be better to use 'ratioReward' as stakeRewardActiveValidators for terminology alignment.
Line 271: I think isSeedRevealValid() and impliesMaximalPrevotes() checks should be done in beforeTransactionsExecute().
Not sure if it is true but CONTEXT_STORE_KEY_BLOCK_REWARD is set in "afterTransactionsExecute()"
Missing Tests
Should not store timestamp when it is not end of round
When every validator in a round miss the blocks, check endofRoundTimestamp and blockreward.
Check should be done similar to Reward module for rewardAtHeight.
The text was updated successfully, but these errors were encountered:
module.spec.ts
//
. Line 157, 222, 300 has/
.(bftWeight * stakeRewardActiveValidators)//bftWeightSum
. Also would be better to use 'ratioReward' asstakeRewardActiveValidators
for terminology alignment.isSeedRevealValid()
andimpliesMaximalPrevotes()
checks should be done inbeforeTransactionsExecute()
.CONTEXT_STORE_KEY_BLOCK_REWARD
is set in "afterTransactionsExecute()"Missing Tests
The text was updated successfully, but these errors were encountered: