Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Unit test review: Dynamic block rewards #8025

Closed
Tracked by #7245
vjaiman opened this issue Jan 17, 2023 · 0 comments
Closed
Tracked by #7245

Unit test review: Dynamic block rewards #8025

vjaiman opened this issue Jan 17, 2023 · 0 comments
Assignees
Milestone

Comments

@vjaiman
Copy link

vjaiman commented Jan 17, 2023

module.spec.ts

  • In LIP we use integer division//. Line 157, 222, 300 has /.
  • line 222: BigInt(5) should be properly formulated considering (bftWeight * stakeRewardActiveValidators)//bftWeightSum. Also would be better to use 'ratioReward' as stakeRewardActiveValidators for terminology alignment.
  • Line 271: I think isSeedRevealValid() and impliesMaximalPrevotes() checks should be done in beforeTransactionsExecute().
  • Not sure if it is true but CONTEXT_STORE_KEY_BLOCK_REWARD is set in "afterTransactionsExecute()"

Missing Tests

  • Should not store timestamp when it is not end of round
  • When every validator in a round miss the blocks, check endofRoundTimestamp and blockreward.
  • Check should be done similar to Reward module for rewardAtHeight.
@vjaiman vjaiman self-assigned this Jan 17, 2023
@shuse2 shuse2 removed the type: bug label May 23, 2023
@Madhulearn Madhulearn added this to the Sprint 105 milestone Sep 26, 2023
@Madhulearn Madhulearn modified the milestones: Sprint 105, Sprint 106 Oct 9, 2023
@Madhulearn Madhulearn modified the milestones: Sprint 106, Sprint 107 Oct 24, 2023
@Madhulearn Madhulearn modified the milestones: Sprint 107, Sprint 108 Nov 7, 2023
@Madhulearn Madhulearn moved this from Done to In Progress in Lisk SDK Version 6.1.0 Nov 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants