Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

BFT properties min precommit height calculation error overwrite in finality in case of recompute need to be fixed #4808

Closed
shuse2 opened this issue Feb 10, 2020 · 0 comments
Closed

BFT properties min precommit height calculation error overwrite in finality in case of recompute need to be fixed #4808

shuse2 opened this issue Feb 10, 2020 · 0 comments
Assignees
@shuse2
Labels
type: bug
Milestone
Sprint 13

Comments

@shuse2
Copy link
Collaborator

shuse2 commented Feb 10, 2020 •
edited by nazarhussain
Loading

Expected behavior

  • Finality should not be reset to the initial value while recomputing
  • it should not throw error when looking for _getValidMinHeightToCommit

Actual behavior

  • Finality is reset to original value
  • if there is no cache, it fails to get _getValidMinHeightToCommit
@shuse2 shuse2 mentioned this issue Feb 10, 2020
Merged
@shuse2 shuse2 added this to the Sprint 13 milestone Feb 10, 2020
shuse2 added a commit that referenced this issue Feb 11, 2020
@shuse2
Merge pull request #4811 from LiskHQ/fix_invalid_height_access_and_fi…
bb235ca 
…nality

Fix wrong min precommit height and overwrite of finality - Closes #4808
@shuse2 shuse2 self-assigned this Feb 11, 2020
@shuse2 shuse2 closed this as completed Feb 11, 2020
@nazarhussain nazarhussain changed the title BFT properties calculation does not follow the LIP BFT properties min precommit height calculation error overwrite in finality in case of recompute need to be fixed Feb 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@shuse2 shuse2

Labels
type: bug
Projects
None yet
Milestone
Sprint 13
Development

No branches or pull requests
1 participant
@shuse2