Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

It should not assign to the env variable #4779

Closed
shuse2 opened this issue Feb 3, 2020 · 0 comments
Closed

It should not assign to the env variable #4779

shuse2 opened this issue Feb 3, 2020 · 0 comments
Assignees
Milestone

Comments

@shuse2
Copy link
Collaborator

shuse2 commented Feb 3, 2020

Expected behavior

In the code, it should never insert value to environment variable

Actual behavior

In cryptography, it is inserting the environment variable, and fails on the webpack build
https://github.com/LiskHQ/lisk-sdk/blob/master/elements/lisk-cryptography/src/nacl/index.ts#L28

Which version(s) does this affect? (Environment, OS, etc...)

3.0-

@shuse2 shuse2 self-assigned this Feb 3, 2020
@shuse2 shuse2 added this to the Sprint 12 milestone Feb 3, 2020
shuse2 added a commit that referenced this issue Feb 3, 2020
@shuse2 shuse2 closed this as completed Feb 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant