Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Fix all the fragile P2P test for consistant result #4651

Closed
ManuGowda opened this issue Dec 20, 2019 · 2 comments
Closed

Fix all the fragile P2P test for consistant result #4651

ManuGowda opened this issue Dec 20, 2019 · 2 comments

Comments

@ManuGowda
Copy link
Contributor

Expected behavior

The p2p test suite should consistently pass on development and release/3.0.0 branch

Actual behavior

Few of the p2p tests are fragile, this leads to multiple build failures causing interruption for development and slowness and inconsistency with the test.
Following are the tests:

  • getBucketId: should return different buckets for same target address and source address but different peerType -> test/unit/utils/misc.ts:356
  • p2p.send: should send a message to peers; should reach peers with even distribution -> test/functional/actions/send.ts:75

Steps to reproduce

Looking to jenkins job, many PRs are failing due to these common tests failures

Which version(s) does this affect? (Environment, OS, etc...)

3.0.0, development

@valamidev
Copy link
Contributor

Related to #4654

@ManuGowda ManuGowda added this to the Next Sprint milestone Jan 6, 2020
shuse2 added a commit that referenced this issue Jan 8, 2020
Migrate P2P tests under Jest framework - Closes #4642 & #4651
@shuse2
Copy link
Collaborator

shuse2 commented Jan 9, 2020

Closed by #4654

@shuse2 shuse2 closed this as completed Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants