Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

P2P PeerBook newPeers and tiredPeers lists should be disjoint #4609

Closed
valamidev opened this issue Dec 6, 2019 · 0 comments · Fixed by #4616
Closed

P2P PeerBook newPeers and tiredPeers lists should be disjoint #4609

valamidev opened this issue Dec 6, 2019 · 0 comments · Fixed by #4616

Comments

@valamidev
Copy link
Contributor

Expected behavior

  • Peers in the PeerBook newPeers / tiredPeers never exist in both list.

Actual behavior

  • When baseList.removePeer() fail it could occur that Peers are remain in the list.

Steps to reproduce

  • With the code sample below it can be reproduced.
if (!peerBook.hasPeer(peerInfo)) {
					peerBook.addPeer(peerInfo);
	}

	peerBook.upgradePeer(peerInfo);
});

Which version(s) does this affect? (Environment, OS, etc...)

3.0

@valamidev valamidev self-assigned this Dec 6, 2019
@sridharmeganathan sridharmeganathan added this to the Sprint 11 milestone Dec 9, 2019
ManuGowda added a commit that referenced this issue Dec 10, 2019
P2P peerBook disjoint fix and test improvements - Closes #4609 & #4599
diego-G pushed a commit to diego-G/lisk-sdk that referenced this issue Dec 12, 2019
…sjoint-fix

P2P peerBook disjoint fix and test improvements - Closes LiskArchive#4609 & LiskArchive#4599
sign: Diego Garcia <diego.gm@protonmail.com>
diego-G pushed a commit to diego-G/lisk-sdk that referenced this issue Dec 12, 2019
…sjoint-fix

P2P peerBook disjoint fix and test improvements - Closes LiskArchive#4609 & LiskArchive#4599
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants