Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Do not include nonce when broadcasting #3702

Closed
diego-G opened this issue May 22, 2019 · 0 comments · Fixed by #4472
Closed

Do not include nonce when broadcasting #3702

diego-G opened this issue May 22, 2019 · 0 comments · Fixed by #4472
Assignees
@diego-G
Milestone
Sprint 9

Comments

@diego-G
Copy link

diego-G commented May 22, 2019 •
edited by shuse2
Loading

Expected behavior

The node broadcast only the necessary data. Remember that we won't have to validate the nonce in the schema either (transactions, signatures and blocks).
https://github.com/LiskHQ/lisk-sdk/blob/008d6d20292aa0e54a82a4c44999e649fa786be0/framework/src/modules/chain/schema/definitions.js#L118

The nonce property should be removed from all of the RPC endpoints response and validation.

Actual behavior

Nonce is broadcast together with the objects but never used.
https://github.com/LiskHQ/lisk-sdk/blob/008d6d20292aa0e54a82a4c44999e649fa786be0/framework/src/modules/chain/logic/broadcaster.js#L109

Which version(s) does this affect? (Environment, OS, etc...)

1.0.0+
@sridharmeganathan sridharmeganathan added this to the Sprint 5 milestone Aug 20, 2019
@diego-G diego-G self-assigned this Nov 4, 2019
@diego-G diego-G mentioned this issue Nov 5, 2019
Merged
5 tasks
shuse2 added a commit that referenced this issue Nov 6, 2019
@shuse2
Merge pull request #4472 from LiskHQ/3702-remove_nonce_when_broadcasting
8ce829b 
Remove nonce from framework chain submodule - Closes #3702
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diego-G diego-G

Labels
None yet
Projects
None yet
Milestone
Sprint 9
Development

Successfully merging a pull request may close this issue.

Remove nonce from framework chain submodule - Closes #3702 LiskArchive/lisk-sdk
3 participants
@diego-G @shuse2 @sridharmeganathan