Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Discovery is too reliant on seed peers #3643

Closed
jondubois opened this issue May 16, 2019 · 1 comment
Closed

Discovery is too reliant on seed peers #3643

jondubois opened this issue May 16, 2019 · 1 comment

Comments

@jondubois
Copy link
Contributor

Expected behavior

The discovery should start with the seed peers but when the interval executes again, it should use some of the newly discovered peers as the new seeds.

Actual behavior

There is a bug in the current discovery algorithm which means that our node always go back to the seed peers for discovery.

Steps to reproduce

Check the code.

Which version(s) does this affect? (Environment, OS, etc...)

0.1.0-alpha.9

@jondubois jondubois self-assigned this May 16, 2019
@ishantiw
Copy link
Contributor

@jondubois I think we need to use triedPeers and newPeers or just triedPeers when we start discovering in intervals, seems like we are just passing seed peers again and again, every time we do discovery,
https://github.com/LiskHQ/lisk-sdk/blob/development/elements/lisk-p2p/src/p2p.ts#L562

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants