Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Use async/await in chain module logic #3540

Closed
ishantiw opened this issue May 7, 2019 · 0 comments · Fixed by #3729
Closed

Use async/await in chain module logic #3540

ishantiw opened this issue May 7, 2019 · 0 comments · Fixed by #3729
Assignees
@ishantiw
Labels
framework type: refactoring

Comments

@ishantiw
Copy link
Contributor

ishantiw commented May 7, 2019 •
edited by MaciejBaj
Loading

Expected behavior

Use async/await consistently across the application.

Don't introduce any changes to rounds! The parallel changes will be introduced to Lisk SDK 3.0

Actual behavior

There is the use of callbacks in the constructor and methods of logic classes. Also, the sequence of callbacks is not consistent.

Related to #3396

Which version(s) does this effect? (Environment, OS, etc...)

*
@ishantiw ishantiw self-assigned this May 7, 2019
@MaciejBaj MaciejBaj changed the title Use async await in chain module logic Use async/await in chain module logic May 16, 2019
@ishantiw ishantiw mentioned this issue May 24, 2019
Merged
shuse2 added a commit that referenced this issue Jun 4, 2019
@shuse2
Merge pull request #3729 from LiskHQ/3540-use_async_await_chain_modul…
7768c2c 
…e_logic

Remove callbacks from chain account logic - Closes #3540
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ishantiw ishantiw

Labels
framework type: refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove callbacks from chain account logic - Closes #3540 LiskArchive/lisk-sdk
1 participant
@ishantiw