Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

init_transaction module not extensible to custom transactions #3429

Closed
mitsuaki-u opened this issue Apr 23, 2019 · 1 comment
Closed

init_transaction module not extensible to custom transactions #3429

mitsuaki-u opened this issue Apr 23, 2019 · 1 comment
Assignees

Comments

@mitsuaki-u
Copy link
Contributor

mitsuaki-u commented Apr 23, 2019

Expected behavior

logic/init_transaction module should be extensible to accommodate for new custom transaction types created by sdk user.

Actual behavior

logic/init_transaction module directly maps known transaction types to raw db format.

See issue #2424

Which version(s) does this affect? (Environment, OS, etc...)

1.7

@2snEM6
Copy link
Contributor

2snEM6 commented Apr 25, 2019

Also elements/lisk-transactions/src/utils/validation/schema.ts:111 is setting the maximum value for BaseTransaction type to be 7. This constraint needs to be removed so we can register custom transactions with a type > 7

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants