Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Remove symlinks from HTTP API module #3047

Closed
2snEM6 opened this issue Mar 11, 2019 · 1 comment · Fixed by #3056
Closed

Remove symlinks from HTTP API module #3047

2snEM6 opened this issue Mar 11, 2019 · 1 comment · Fixed by #3056
Assignees

Comments

@2snEM6
Copy link
Contributor

2snEM6 commented Mar 11, 2019

Expected behavior

HTTP API should have symlinks in helpers folder

Actual behavior

HTTP API has symlinks poining to chain/helpers folder. This was done as a temporary solution to avoid duplicated files due to the extraction of api logic from Chain module to a separate module HTTP API.

Symlinks are also causing problems with npm pack.

What we have to do now is:

  • Remove symlinks
  • See what to do with the shared logic between Chain and HTTP API modules on helpers module so no files are left duplicated and no symlinks are present either.

Address this Issue ONLY after #3020 is merged.

Steps to reproduce

Which version(s) does this affect? (Environment, OS, etc...)

development branch

@2snEM6
Copy link
Contributor Author

2snEM6 commented Mar 11, 2019

Address this Issue ONLY after #3020 is merged.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant