Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Validate filters for getter methods in Account and Transaction entities #3005

Closed
lsilvs opened this issue Mar 1, 2019 · 0 comments · Fixed by #3105
Closed

Validate filters for getter methods in Account and Transaction entities #3005

lsilvs opened this issue Mar 1, 2019 · 0 comments · Fixed by #3105
Assignees

Comments

@lsilvs
Copy link
Contributor

lsilvs commented Mar 1, 2019

Expected behavior

I expect the storage entities Account and Transaction to validate the passed filters and throw and error if a filter is not valid.
Also, unit tests should be added to cover this scenario.

Actual behavior

Currently it doesn't and the database query crashes with an unclear message

Steps to reproduce

Run storage.entities.Transaction.get({ invalid_filter: true })

Which version(s) does this affect? (Environment, OS, etc...)

1.5

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants