This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
Suggest making an outgoing transaction - Closes #1019 #1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slaweet
force-pushed
the
1019-suggest-outgoing-transaction
branch
3 times, most recently
from
5eca251 to
f8ada95
Compare
... if in an uninitialized account
slaweet
force-pushed
the
1019-suggest-outgoing-transaction
branch
from
f8ada95 to
d876a50
Compare
... to account.publicKey === null
slaweet
force-pushed
the
1019-suggest-outgoing-transaction
branch
from
21d2913 to
dd75131
Compare
so that we don't have to worry about that link being possibly broken in future
there were two problems: - the change of the publicKey from server was not sent from each accountUpdated action - storing boolean value didn't work because account reducer merge function doesn't correctly merge boolean values
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
There was no hint to users that they should make an outgoing transaction to save their publicKey on the blockchain.
How did I fix it?
I implemented an infobox that suggests to users without outgoing transactions to make one.
How to test it?
Review checklist