Write e2e tests for onboarding - Closes #589 #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginacontrino
force-pushed
the
589-onboarding-tests
branch
from
b353c65 to
bf1b496
Compare
ginacontrino
force-pushed
the
589-onboarding-tests
branch
from
bf1b496 to
65ab13f
Compare
ginacontrino
changed the title
ginacontrino
force-pushed
the
589-onboarding-tests
branch
from
65ab13f to
047453e
Compare
ginacontrino
force-pushed
the
589-onboarding-tests
branch
from
047453e to
6b5700e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
We had no e2e tests for the onboarding
How did I fix it?
Added the tests
How to test it?
Read through the tests & make sure every scenario is covered + run them
Review checklist