Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix undefined e2e tests not failing - Closes #607 #614

Merged
merged 1 commit into from
Mar 26, 2018
Merged

Fix undefined e2e tests not failing - Closes #607 #614

merged 1 commit into from
Mar 26, 2018

Conversation

michaeltomasik
Copy link
Contributor

What was the problem?

Undefined e2e tests were passing

How did I fix it?

Added strict mode

How to test it?

  • Add test with undefined instruction
  • Run test command
  • And see If test fail.

screen shot 2018-03-26 at 14 52 46

Review checklist

@michaeltomasik michaeltomasik self-assigned this Mar 26, 2018
slaweet
slaweet approved these changes Mar 26, 2018
View reviewed changes
Copy link
Contributor

@slaweet slaweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@michaeltomasik michaeltomasik merged commit 5342d1e into 0.4.0 Mar 26, 2018
@michaeltomasik michaeltomasik deleted the 607-undefned-e2e-should-fail-scenario branch March 26, 2018 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slaweet slaweet slaweet approved these changes

@yasharAyari yasharAyari Awaiting requested review from yasharAyari

Assignees

@michaeltomasik michaeltomasik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaeltomasik @slaweet