Make address in account switcher copyable - Closes #594 #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faival
previously approved these changes
Mar 26, 2018
slaweet
suggested changes
Mar 26, 2018
There was a problem hiding this comment.
There is quite a disproportion between font weight of the address and the copy icon.
In designs it was more balanced:
https://drive.google.com/drive/u/2/folders/1_xQMcDWQsbPqM_7gstEpQCNb8CWtqkBy
slaweet
approved these changes
Mar 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
Address in account switcher was not copyable
How did I fix it?
Wrapped
copyToClipboardaround the addressHow to test it?
Try to copy the address
Review checklist