Add new account component design - Closes #553 #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slaweet
suggested changes
Mar 27, 2018
There was a problem hiding this comment.
- Please check again the font-family, font-size, and font-weight of balance and address in the design. It doesn't look right.
- The copy-to-clipboard icon should be bigger compared to the font-size of the address
- The copy-to-clipboard icon should be on the left in the header, but still on the right in all other occurrences.
michaeltomasik
force-pushed
the
553-update-account-component-design
branch
from
2763676 to
bfb2766
Compare
michaeltomasik
force-pushed
the
553-update-account-component-design
branch
from
bfb2766 to
1a9cd79
Compare
slaweet
force-pushed
the
553-update-account-component-design
branch
from
4dc83a3 to
c594198
Compare
faival
pushed a commit
that referenced
this pull request
Mar 29, 2018
Add new account component design - Closes #553
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
Old account component design
How did I fix it?
I added new design ex.
reset timerHow to test it?
Go to issue ticket and check each scenario.
Review checklist