Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup @advanced tag for e2e test scenarios - Closes #559 #597

Merged
merged 4 commits into from
Mar 23, 2018

Conversation

ginacontrino
Copy link
Contributor

@ginacontrino ginacontrino commented Mar 22, 2018

What was the problem?

Some e2e tests don't need to be run every time

How did I fix it?

By adding the @advanced tag

How to test it?

Run the build on Jenkins and check that the @advanced e2e tests are skipped

Review checklist

@ginacontrino ginacontrino force-pushed the 559-setup-advanced-test-tag branch from ae903db to 2b87f22 Compare March 22, 2018 15:08
slaweet
slaweet previously approved these changes Mar 22, 2018
Copy link
Contributor

@slaweet slaweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@slaweet slaweet dismissed their stale review March 22, 2018 20:00

e2e tests made more unstable

@ginacontrino ginacontrino force-pushed the 559-setup-advanced-test-tag branch from 8f373be to 5af6ba0 Compare March 23, 2018 10:37
Copy link
Contributor

@slaweet slaweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ginacontrino ginacontrino merged commit 622f05b into 0.4.0 Mar 23, 2018
@ginacontrino ginacontrino deleted the 559-setup-advanced-test-tag branch March 23, 2018 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants