Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stuck on loading screen on transaction details - Closes #565 #574

Merged
merged 4 commits into from
Mar 20, 2018

Conversation

faival
Copy link
Contributor

@faival faival commented Mar 19, 2018

What was the problem?

clicking on a transactionRow of an account doesn't display it's details.

How did I fix it?

  • Avoid usage of this.props on presentational components.
  • nextStep should pass value from props.
  • add integration tests

How to test it?

go to /explorer/accounts/5932438298200837883L, and click on a transaction row:

  • detailView of that transaction must be displayed.

Review checklist

@faival faival self-assigned this Mar 19, 2018
@faival faival requested a review from slaweet March 19, 2018 17:11
@faival faival changed the title 565 stuck on loading screen on transaction details 565 stuck on loading screen on transaction details - Closes #565 Mar 19, 2018
@slaweet slaweet changed the title 565 stuck on loading screen on transaction details - Closes #565 Fix stuck on loading screen on transaction details - Closes #565 Mar 20, 2018
Copy link
Contributor

@slaweet slaweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Pablo

@faival faival merged commit 5ecdc07 into 0.3.0 Mar 20, 2018
@faival faival deleted the 565-stuck-on-loading-screen-on-transaction-details branch March 20, 2018 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants