Fix vote launch protocol - Closes #279 #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slaweet
changed the title
michaeltomasik
force-pushed
the
279-fix-launch-protocol-for-vate
branch
from
245b736 to
e663e62
Compare
slaweet
suggested changes
Mar 26, 2018
michaeltomasik
force-pushed
the
279-fix-launch-protocol-for-vate
branch
from
edcdd65 to
1560ef9
Compare
slaweet
approved these changes
Mar 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
Opening voting url with
liskprotocol opens electron app with old modalHow did I fix it?
Remove old modal and make delegate selection on new UI in delegates section
How to test it?
Review checklist