Fix the launch protocol for send - Closes #280 #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginacontrino
force-pushed
the
280-send-launch-protocol
branch
2 times, most recently
from
be61bbc to
cea76f9
Compare
ginacontrino
force-pushed
the
280-send-launch-protocol
branch
from
cea76f9 to
7235ec0
Compare
ginacontrino
force-pushed
the
280-send-launch-protocol
branch
from
5c9ad96 to
6b38fd6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
Prefilling the send form with an amount did not work yet
How did I fix it?
Made it work for the amount as well
How to test it?
While being logged in, try for example
http://localhost:8080/#/main/transactions?address=16313739661670634666L&amount=2the send form should be filled after that
Review checklist