Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make address in header copyable - Closes #468 #548

Merged
merged 2 commits into from
Mar 14, 2018
Merged

Make address in header copyable - Closes #468 #548

merged 2 commits into from
Mar 14, 2018

Conversation

ginacontrino
Copy link
Contributor

@ginacontrino ginacontrino commented Mar 13, 2018 •
edited
Loading

What was the problem?

The address in the header was not copyable

How did I fix it?

  • Used the CopyToClipboard component
  • I also right-aligned the lock icon so both icons are on the same side

How to test it?

Try to copy the address

Review checklist

@ginacontrino ginacontrino self-assigned this Mar 13, 2018
@ginacontrino ginacontrino changed the title Make address in header copyable Make address in header copyable - Closes #468 Mar 13, 2018
@ginacontrino ginacontrino requested a review from slaweet March 14, 2018 11:23
slaweet
slaweet approved these changes Mar 14, 2018
View reviewed changes
Copy link
Contributor

@slaweet slaweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Gina

@ginacontrino ginacontrino merged commit 62bfbd2 into 0.3.0 Mar 14, 2018
@ginacontrino ginacontrino deleted the 468-copy-address branch March 14, 2018 14:12
@snyk-bot snyk-bot mentioned this pull request Jan 12, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Feb 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slaweet slaweet slaweet approved these changes

@yasharAyari yasharAyari Awaiting requested review from yasharAyari

Assignees

@ginacontrino ginacontrino

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ginacontrino @slaweet