Refactor route definition - Closes #499 #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yasharAyari
suggested changes
Mar 12, 2018
src/constants/routes.js
Outdated
| dashboard: { url: '/dashboard' }, | ||
| search: { url: '/search' }, | ||
| searchResult: { url: '/result' }, | ||
| transaction: { url: '/transactions' }, |
There was a problem hiding this comment.
why did you remove short routes ?
src/components/login/login.test.js
Outdated
| @@ -85,18 +86,18 @@ describe('Login', () => { | |||
| }); | |||
|
|
|||
| describe('History management', () => { | |||
| it('calls this.props.history.replace(\'/main/dashboard\')', () => { | |||
| it(`calls this.props.history.replace('${routes.main}${routes.dashboard.url}')`, () => { | |||
There was a problem hiding this comment.
Please update the it blocks with descriptions that are more readable (as you were already changing them anyway). We want to avoid exactly the situation that you were in here, where when we change some implementation, the describe blocks have to be updated too. Instead, by having a general readable description of what we are expecting, there will be no need to always update the blocks. So one possible example could be, instead of
calls this.props.history.replace('${routes.main}${routes.dashboard.url}') -> redirects to dashboard
src/utils/routes.js
Outdated
| params: 'query', | ||
| name: 'result', | ||
| }, { | ||
| regex: /\/explorer\/search(?:\/[^/]*)?$/, | ||
| path: `${routes.search.long}/`, | ||
| path: `/explorer${routes.search.url}/`, |
There was a problem hiding this comment.
Why not ${routes.explorer} instead of /explorer?
michaeltomasik
force-pushed
the
499-refactor-route-definitions
branch
from
25ef2ae to
abb5f11
Compare
…iskHQ/lisk-hub into 499-refactor-route-definitions
yasharAyari
approved these changes
Mar 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
Some routes definitions were in the string
How did I fix it?
Created constants for route
How to test it?
Search for
mainandexplorerto check if route definition comes from one fileReview checklist