Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post Slack notifications to lisk-ci-hub channel #537

Merged
merged 1 commit into from
Mar 9, 2018
Merged

Conversation

fchavant
Copy link
Contributor

@fchavant fchavant commented Mar 8, 2018

What was the problem?

Slack notifications were being posted to the old channel instead of lisk-ci-hub

How did I fix it?

The logic to generate the channel name was changed: now the job base name name is taken and lisk- is replaced with lisk-ci-.

How to test it?

Build this PR in Jenkins.

Copy link
Contributor

@slaweet slaweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fchavant fchavant merged commit b08dcc5 into 0.3.0 Mar 9, 2018
@fchavant fchavant deleted the slack-lisk-ci-hub branch March 9, 2018 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants