Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the desktop app icon - Closes #495 #518

Merged
merged 4 commits into from
Mar 6, 2018
Merged

Update the desktop app icon - Closes #495 #518

merged 4 commits into from
Mar 6, 2018

Conversation

faival
Copy link
Contributor

@faival faival commented Mar 5, 2018 •
edited
Loading

What was the problem?

icons for desktop app are outdated and need to be updated

How did I fix it?

replace assets in project

How to test it?

see new generated ios bundle, install desktop app, check for icons in:

  • DMG Install dialog
  • Spotlight search
  • Applications bottom Bar
  • Tab view on active applications
  • Applications folder

Review checklist

  • The PR solves Update the desktop app icon #495
  • All new code is covered with unit tests
  • All new features are covered with e2e tests
  • All new code follows best practices

@faival faival requested a review from slaweet March 6, 2018 09:01
slaweet
slaweet approved these changes Mar 6, 2018
View reviewed changes
Copy link
Contributor

@slaweet slaweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @faival

@faival faival merged commit 1878da0 into 0.3.0 Mar 6, 2018
@faival faival deleted the 495-update-the-desktop-app-icon branch March 6, 2018 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slaweet slaweet slaweet approved these changes

Assignees

@faival faival

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@faival @slaweet